Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT allelles #2832

Open
ValWood opened this issue May 7, 2024 · 2 comments
Open

WT allelles #2832

ValWood opened this issue May 7, 2024 · 2 comments

Comments

@ValWood
Copy link
Member

ValWood commented May 7, 2024

We recently made it so that users could add WT alleles. Maybe we should make this 'admin only' because I just had a session with lots of WT[WT le el] alleles included which made them all muli gene phenotypes.

We should monitor if this recurs (there were quite a few in my session >20)

@kimrutherford kimrutherford self-assigned this May 9, 2024
@kimrutherford
Copy link
Member

We recently made it so that users could add WT alleles.

I thought users could always add WT alleles?

We changed the code recently to allow "Not assayed" for WT alleles: #2818 (comment)

Is that what's happening?

@ValWood
Copy link
Member Author

ValWood commented May 9, 2024

Yes you are correct, I think we have been able to use them since diploids were introduced.
We should discuss in which placed WT alleles are appropriate and then add blocks and messaging to lead users to the correct way to curate in these instances.

The one I just removed was where the user had included the WT allele for the assayed gene. There are probably other cases. We will add to this ticket. It isn't super urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants