Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write approver ORCID to exported JSON file #2789

Open
kimrutherford opened this issue Oct 23, 2023 · 4 comments
Open

Write approver ORCID to exported JSON file #2789

kimrutherford opened this issue Oct 23, 2023 · 4 comments

Comments

@kimrutherford
Copy link
Member

We need to load the ORCID of the session approver to JSON so we can load into Chado:

@ValWood
Copy link
Member

ValWood commented Oct 23, 2023

There could be a small complication here. The main approver is the [person who does the initial approval. Subsequently when we do minor edits to a session we reapprove the session and the person who makes a minor change becomes the approver. Really we want to credit the first approver (who did the bulk of the checking).

However, we have also talked briefly about recording the removal of annotations. This would be useful for stats , and we are encouraged to collect this data too.

We should chat about both of these issues next time we chat.

@kimrutherford
Copy link
Member Author

However, we have also talked briefly about recording the removal of annotations

Is that existing annotations or new annotations from the current session?

@kimrutherford
Copy link
Member Author

Really we want to credit the first approver (who did the bulk of the checking).

The previous approver(s) aren't recorded in Canto so wouldn't be able to do that for old sessions. We can change the code to capture that in future.

@ValWood
Copy link
Member

ValWood commented Oct 24, 2023

We might be able to establish historical approver from curation additions (not urgent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants