Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress indicator during database generation #2

Open
romainsacchi opened this issue Sep 17, 2023 · 5 comments
Open

Add progress indicator during database generation #2

romainsacchi opened this issue Sep 17, 2023 · 5 comments

Comments

@romainsacchi
Copy link
Collaborator

No description provided.

@marc-vdm
Copy link
Member

Could you point me to the functions in unfold where the progressbars are printed to the terminal?

I've looked at the AB progressbars, it seems we overwrite the classes in Brightway that take the different steps (extract/apply strategies etc) and update progress bar from there. Perhaps we could do something similar to this for unfold if it's not too complicated.

@romainsacchi
Copy link
Collaborator Author

It happens here:

Unfold(filepath).unfold(

@marc-vdm
Copy link
Member

Yes, sorry, I mean the specific functions in unfold

@romainsacchi
Copy link
Collaborator Author

@bsteubing
Copy link

bsteubing commented Sep 26, 2023

would be nice to have... the download now took some 4-5 minutes, so a progress bar would be great.
And even more important for the data extraction / database generation... which took certainly 20min or so, so here we really need a progress indicator... and perhaps a warning ahead of time to the user that this will take some time.

Lastly: it is unclear where the data is stored. Perhaps the user could directly indicate where he wants to store it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants