-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extendr #1105
Comments
I've looked at this and there are a lot of breaking changes and I don't think I can fix them right away, so I'd like to postpone this. |
Do you want to open a draft PR for this? |
Nope. I have nothing to share as I have modified almost nothing. |
@CGMossa Any advice for this? |
Yes! There are a lot of breaking changes, but they should be easy to update. You can start on it, and if anything seems odd, you can ping me again, and I'll have a look or respond immediately. I've basically aimed to remove all the weird options, and improve default behavior.. Very little has simply disappeared from extendr. |
I read https://stat.ethz.ch/pipermail/r-package-devel/2024q2/010931.html.
@JosiahParry Sorry but could you please take a look at this repository? Due to extendr, I don't think we have been able to pass CI for a while. |
Sorry! been busy going to take a look :) |
Is there a doc on building r-polars? It appears to require some CMake magic that is incompatible with my machine. |
This comment was marked as outdated.
This comment was marked as outdated.
Also some info here: https://github.com/pola-rs/r-polars/blob/main/DEVELOPMENT.md |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@JosiahParry Thanks for taking a look at this. Maybe I've made you do it twice. I was mistaken in thinking that you guys were keeping in touch. I am sorry. |
Since #851 seems to have been resolved by extendr dev version, we should be able to revert the workaround #874.
The text was updated successfully, but these errors were encountered: