Make createPlayer have a small delay #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give the Network a little bit of time to connect to the signalling backend before we continue with the next step. This makes our tests less flakey.
Pedr0Rocha
approved these changes
Jun 17, 2024
koenbollen
approved these changes
Jun 17, 2024
|
Lowered it to 50ms, with lower tests sometimes fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give the Network a little bit of time to connect to the signalling backend before we continue with the next step. This makes our tests less flaky. Found out when some lobby tests where we create multiple players after each other was failing because their ID was changing (as they are given out in order).