Update custom data #106
Merged
Update custom data #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
force-pushed
the
update-custom-data
branch
from
b89d66d
to
381c488
Compare
erikdubbelboer
force-pushed
the
update-custom-data
branch
from
7a6fa0d
to
1f72973
Compare
koenbollen
reviewed
Jun 25, 2024
| @@ -153,7 +153,7 @@ func (s *PostgresStore) Publish(ctx context.Context, topic string, data []byte) | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *PostgresStore) CreateLobby(ctx context.Context, game, lobbyCode, peerID string, public bool, customData map[string]any) error { | |||
| func (s *PostgresStore) CreateLobby(ctx context.Context, game, lobbyCode, peerID string, public bool, customData map[string]any, canUpdateBy string) error { | |||
There was a problem hiding this comment.
I feel like this argument list is getting quite long. Is it time for a struct?
There was a problem hiding this comment.
We'll do this when implementing password/maxplayer editing.
erikdubbelboer
force-pushed
the
update-custom-data
branch
from
1f72973
to
69103d6
Compare
Add new canUpdateBy to lobby to indicate which peers can update the lobby data.
erikdubbelboer
force-pushed
the
update-custom-data
branch
from
69103d6
to
74a0cd5
Compare
Co-authored-by: Koen Bollen <[email protected]>
koenbollen
approved these changes
Jun 28, 2024
Co-authored-by: Koen Bollen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.