Remove code for fakeJoinPacket on reconnect #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was added 2 years ago together with the TimeoutManager. It is currently impossible to leave a lobby while being disconnected, so the code isn't needed anymore. This code was probably only for backwards compatibility with existing lobbies when it was deployed.
Pedr0Rocha
approved these changes
Jun 17, 2024
|
The only big different, is that the other peers won't get a joined packet anymore (that was broadcasted in HandleJoinPacket. |
koenbollen
approved these changes
Jun 17, 2024
|
As discussed on Discord, this code is never hit anymore since it's not possible to leave a lobby while being disconnected. This was really only for backwards compatibility when the TimeoutManager was initially released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was added 2 years ago together with the TimeoutManager. It is currently impossible to leave a lobby while being disconnected, so the code isn't needed anymore. This code was probably only for backwards compatibility with existing lobbies when it was deployed.