Have a topic per lobby #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
force-pushed
the
subscribe-lobby
branch
from
056f598
to
2c4aa09
Compare
koenbollen
reviewed
Jun 17, 2024
koenbollen
approved these changes
Jun 17, 2024
Instead of always getting a list of peers and pushing a message to each of then, we Subscribe on a lobby topic as well so we can publish on that.
erikdubbelboer
force-pushed
the
subscribe-lobby
branch
from
2cbb52a
to
ee294f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always getting a list of peers and pushing a message to each of then, we Subscribe on a lobby topic as well so we can publish on that.