Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot dispatch PLAYER_INIT with URL as payload instead of config object #118

Open
Connum opened this issue Oct 23, 2019 · 1 comment
Open

Comments

@Connum
Copy link

Connum commented Oct 23, 2019

When programmatically dispatching PLAYER_INIT, I would have expected to be able to pass an URL instead of a configuration object, just like when using podlovePlayer().

{
  "type": "PLAYER_INIT",
  "payload": "https://freakshow.fm/?podlove_player4=1465"
}

But instead, I end up with the player showing "Fehlende Medien Dateien | Die zur Verfügung gestellte Konfiguration ist fehlerhaft. Ohne Mediendateien kann der Player nichts abspielen.".

It seems kind of counter-intuitive that I have to fetch the config myself and pass it to the player, when the player already has the built-in functionality to do so.

@alexander-heimbuch alexander-heimbuch transferred this issue from podlove/podlove-web-player Oct 24, 2019
@alexander-heimbuch
Copy link
Contributor

Conceptually web-player and player are two separate applications. The web-player parses the initial configuration, fetching references to chapters and transcripts and finally joins it with the additional config (references, base href, ...). Creating the configuration for the player is therefore not part of the core store.

Since this functionality is needed for functionalities like a playlist I've added in the next iteration the ability to fetch episode related data: https://github.com/podlove/podlove-ui/blob/development/packages/player/actions/playlist.js#L5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants