-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web Player Localization - Right-to-left languages support #1162
Comments
Hey, |
I'm glad you're open to help on this. Much appreciated! This is the player translation file ar.json, and this is the subscribe button translation file ar.ts. As for the direction, I've made a couple of changes in the default HTML template, and added a few rules to the CSS style. I added comments where applicable. I've also attached screenshots for your reference. Hope this helps! Let me know if there's anything missing or you need help with. |
It might take a while for the implementation so just to align the expectations. Since I have zero experience with RTL interface designs is it possible that you help me with feedback/testing? |
Yes, totally! I can also help with the HTML templates and any additional CSS that we might need. I'm not very familiar with tailwind but it's not that complex to get around. |
Since I can do the direction stuff locally in the HTML templates and CSS, but can't really add the translation files, I was wondering if it's possible to split this into 2 -or more- milestones where we get to have the translation files included in the next version, and then the direction handling stuff later? |
Hi @alexander-heimbuch, do we have an ETA on when the translation gets to the WP plugin? I have no clue if it's possible to merge that PR. The translation files get smushed inside bootstrap.js and I have no idea how to do that 😅 We've launched the website here: https://watara.org/en/ in a network setup, the podcast subsites are in Arabic only though. Thank you for all the podlove! |
@axraph I think I can manage to get the plugin updated by the weekend 👍 |
We're working on a project and we're building the website on WordPress, utilizing Podlove Publisher and Web Player plugins.
The website and the podcast language is Arabic, which is a right-to-left direction.
We're currently working on translating the UI of the web player "apps/player/lang/en.json" and its subscription button "apps/subscribe-button/lang/en.ts". And will add them when done to include on next update.
As for the direction, we'll have to do many CSS changes to "flip" the player, including actually flipping the progress bar with
transform: scaleX(-1)
, which is a hack and not really an ideal way to support the direction change.I was wondering, would you be interested in doing the RTL support properly? I can share the CSS overrides as a starting point for this.
The text was updated successfully, but these errors were encountered: