Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve frontend test coverage of Q-Select components and signing #22

Open
mds1 opened this issue Apr 14, 2020 · 0 comments
Open

Improve frontend test coverage of Q-Select components and signing #22

mds1 opened this issue Apr 14, 2020 · 0 comments
Assignees
Labels
enhancement Minor improvement to existing functionality

Comments

@mds1
Copy link
Contributor

mds1 commented Apr 14, 2020

This is a continuation of issues not closed by #19, which are:

  1. There are some problems testing q-select dropdown components with Cypress. As a result I have not yet figured out how to fully test the filling out/verifying of the form. Details here
  2. The "connect wallet" functionality is faked by setting the providers, signers, and userAddress to 0x. This just tricks the UI into thinking there is a wallet connected to show the form. Mocking a web3 provider was a bit tricky and not completed in the above PR
@mds1 mds1 added the enhancement Minor improvement to existing functionality label Apr 14, 2020
@mds1 mds1 self-assigned this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Minor improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant