Windows crash on sys.get_output

[CrystalMoogle]

More specifically, getProcessId causes a crash

 inline quint64 getProcessID(const QProcess* proc)
    {
        #ifdef Q_OS_WIN
            struct _PROCESS_INFORMATION* procinfo = proc->pid();
            return procinfo->dwProcessId;
        #else // Linux
            return proc->pid();
        #endif // Q_WS_WIN
    }

Debug marks the crash point being return procinfo->dwProcessId

[HRDepartment]

The types are somewhat wrong, this should be correct

inline qint64 getProcessID(const QProcess* proc)
    {
        #ifdef Q_OS_WIN
            Q_PID procinfo = proc->pid();
            return qint64(procinfo->dwProcessId);
        #else // Linux
            return proc->pid();
        #endif // Q_OS_WIN
    }

If that doesn't fix it it has to be something else.

[coyotte508]

I don't think that's the issue.

But that's an improvement, also a null check should definitely be done

[HRDepartment]

It's a timing issue I'm pretty sure, applications don't have time to start up, the pid will be null. One solution is to make a blocking call to wait until the application has started (there is a function for this), another would be to change how the function behaves.

[HRDepartment]

Another reason why could be because the application could never start up, because it for example doesn't exist. Netcat, for instance, is not a core Windows command.