Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced entra group/app/administrativeunit get/list commands. Closes #6315 #6394

Closed
wants to merge 3 commits into from

Conversation

nanddeepn
Copy link
Contributor

Enhanced entra group/app/administrativeunit get/list commands. Closes #6315

Added the properties option to the following commands:

  • entra group get
  • entra group list
  • entra app get
  • entra app list
  • entra administrativeunit get
  • entra administrativeunit list

@milanholemans
Copy link
Contributor

Thank you, we'll try to have a look at it ASAP!

@Adam-it Adam-it self-assigned this Nov 14, 2024
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanddeepn Awesome work 👏👏👏👏
I noticed one tiny error we may sort out before we proceed 👍

src/utils/entraGroup.ts Outdated Show resolved Hide resolved
@Adam-it
Copy link
Member

Adam-it commented Nov 20, 2024

@nanddeepn may I kindly ask you to also rebase with latest main before we merge this.
Thanks for your awesome work 👍 You Rock 🤩

@Adam-it Adam-it marked this pull request as draft November 20, 2024 21:24
@nanddeepn nanddeepn marked this pull request as ready for review November 25, 2024 11:01
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Awesome work 👏

@Adam-it
Copy link
Member

Adam-it commented Nov 25, 2024

Ready to merge 🚀

@Adam-it
Copy link
Member

Adam-it commented Nov 26, 2024

merged manually.
Awesome work 👏👏👏👏

@Adam-it Adam-it closed this Nov 26, 2024
@nanddeepn nanddeepn deleted the issue-6315 branch November 27, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add the properties option to entra group/app/administrativeunit get/list commands
3 participants