Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rank A BUG] monorail doesn't show changes after staging the file #20

Closed
neopug opened this issue Nov 2, 2024 · 2 comments
Closed

[Rank A BUG] monorail doesn't show changes after staging the file #20

neopug opened this issue Nov 2, 2024 · 2 comments
Assignees

Comments

@neopug
Copy link

neopug commented Nov 2, 2024

Monorail version: monorail 3.1.0
OS: macOS 14.7 (23H124) (Sonoma)
Git: git version 2.39.5 (Apple Git-154)
Description: Monorail doesn't show changes after staging the files (monorail analysis has no targets).
The way to reproduce:

Prereq:

git init monorail-tutorial
cd monorail-tutorial
mkdir shell
echo "date" > shell/test.sh
chmod +x shell/test.sh
cat <<EOF > Monorail.json
{
  "targets": [
    { "path": "shell" }
  ]
}
EOF

Check

> monorail analyze --changes
{"timestamp":"2024-11-02T20:06:10.440414+00:00","changes":[{"path":"Monorail.json"},{"path":"shell/test.sh"}],"targets":["shell"]}
> git add shell/test.sh
> monorail analyze --changes
{"timestamp":"2024-11-02T20:06:37.918368+00:00","changes":[{"path":"Monorail.json"}],"targets":[]}

Desired behavior

Monorail needs to show targets even if the file was staged

@neopug neopug changed the title [BUG] monorail doesn't show changes after staging the file [Rank A BUG] monorail doesn't show changes after staging the file Nov 2, 2024
@pnordahl pnordahl self-assigned this Nov 2, 2024
@pnordahl
Copy link
Owner

pnordahl commented Nov 2, 2024

Taking a look, thanks for the report!

@pnordahl
Copy link
Owner

pnordahl commented Nov 2, 2024

Resolved in #21 and merged.

@pnordahl pnordahl closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants