Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker::unstack() removes tasks from the wrong end of the queue #79

Open
dktapps opened this issue Aug 21, 2022 · 0 comments
Open

Worker::unstack() removes tasks from the wrong end of the queue #79

dktapps opened this issue Aug 21, 2022 · 0 comments

Comments

@dktapps
Copy link
Member

dktapps commented Aug 21, 2022

Contrary to intuitively expected behaviour, unstack() actually removes tasks from the front of the queue, rather than the back.

This is a problem for task executions that expect to have state set up by tasks that preceded them, because the earlier tasks might not have actually executed due to the tasks being dequeued and not executed.

Side note: The entire terminology for Worker is wrong. Stacks are a FILO data structure, which implies that tasks stack()ed will be executed before any other tasks on the queue. This is completely wrong. The correct terminology would be enqueue() and dequeue().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant