Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side command hints #6517

Open
AzaleeX opened this issue Nov 17, 2024 · 1 comment
Open

Client-side command hints #6517

AzaleeX opened this issue Nov 17, 2024 · 1 comment
Labels
Category: UI Related to the user interface (e.g. commands, terminal output) Priority: Low Status: Blocked Depends on other changes which are yet to be completed Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@AzaleeX
Copy link

AzaleeX commented Nov 17, 2024

image

For this to work, PocketMine would need to automatically support command enumerations. I understand this might break backward compatibility, but since this feature is already part of vanilla Minecraft, it logically should be implemented in PocketMine-MP. This would allow for suggestions to appear when typing a command and could also make it interesting to enable the creation of custom command enumerations.

This means that within the Command class, there would be a preparation of the required options. One could consider adding a class or concept such as CommandParamOption or even CommandParamType.

might be interesting for PM-6 ?

@dktapps
Copy link
Member

dktapps commented Nov 17, 2024

This has been proposed many times before, and I say the same thing every time: A proper command argument parser & validation system needs to be implemented on the server side. There are several things that need to be implemented before it makes sense to bother with this.

Without automatic argument parsing, this requires plugin devs to do all of the same work but for only a small fraction of the benefit (not to mention everyone who's tried to add this seems to want to couple the protocol to the command API).

See discussions on related PRs #3871 #4578 #2345 and probably many more I couldn't find in search.

@dktapps dktapps added Priority: Low Type: Enhancement Contributes features or other improvements to PocketMine-MP Status: Blocked Depends on other changes which are yet to be completed Category: UI Related to the user interface (e.g. commands, terminal output) labels Nov 17, 2024
@dktapps dktapps changed the title Suggestions Command Client-side command hints Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: UI Related to the user interface (e.g. commands, terminal output) Priority: Low Status: Blocked Depends on other changes which are yet to be completed Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

No branches or pull requests

2 participants