Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CommandSender->getServer() #6510

Open
dktapps opened this issue Nov 17, 2024 · 0 comments
Open

Remove CommandSender->getServer() #6510

dktapps opened this issue Nov 17, 2024 · 0 comments
Labels
BC break Breaks API compatibility Category: API Related to the plugin API Easy task Probably really easy to do, good task for first-time contributors Type: Enhancement Contributes features or other improvements to PocketMine-MP
Milestone
6.0

Comments

@dktapps
Copy link
Member

dktapps commented Nov 17, 2024 •
edited
Loading

Description

This dependency makes it impossible inconvenient to unit-test CommandSender-related code offline.

Commands that need a Server instance should take it in their constructor instead of requiring a CommandSender to provide it.
@dktapps dktapps added Category: API Related to the plugin API BC break Breaks API compatibility Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Nov 17, 2024
@dktapps dktapps added this to the 6.0 milestone Nov 17, 2024
@dktapps dktapps added the Easy task Probably really easy to do, good task for first-time contributors label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break Breaks API compatibility Category: API Related to the plugin API Easy task Probably really easy to do, good task for first-time contributors Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
Commands rework
Status: Todo
Milestone
6.0
Development

No branches or pull requests
1 participant
@dktapps