Break cycle between Command and CommandMap (aliases, label)

[dktapps]

Description

Have CommandMap track commands' active aliases and "label" (primary alias) instead of Command

Justification

Since a command's active aliases are tracked by Command internally, a Command needs to ensure it is only registered to a single CommandMap at a time.

This is a dumb limitation and requires extra complexity. We could just have the active aliases tracked by CommandMap itself, since they're only actually important to the CommandMap anyway.

Going further, aliases could be entirely removed from Command. They could just be passed as a string[] to CommandMap->register().

In addition, if #6506 were implemented, Command->getName() (primary alias) could be deleted too, as its only actual use is for onCommand().

PocketMine-MP/src/command/Command.php

Lines 139 to 181 in 48a908e

	public function setLabel(string $name) : bool{
	$this->nextLabel = $name;
	if(!$this->isRegistered()){
	$this->label = $name;
	return true;
	}
	return false;
	}
	/**
	* Registers the command into a Command map
	*/
	public function register(CommandMap $commandMap) : bool{
	if($this->allowChangesFrom($commandMap)){
	$this->commandMap = $commandMap;
	return true;
	}
	return false;
	}
	public function unregister(CommandMap $commandMap) : bool{
	if($this->allowChangesFrom($commandMap)){
	$this->commandMap = null;
	$this->activeAliases = $this->aliases;
	$this->label = $this->nextLabel;
	return true;
	}
	return false;
	}
	private function allowChangesFrom(CommandMap $commandMap) : bool{
	return $this->commandMap === null || $this->commandMap === $commandMap;
	}
	public function isRegistered() : bool{
	return $this->commandMap !== null;
	}

PocketMine-MP/src/command/Command.php

Lines 205 to 210 in 48a908e

	public function setAliases(array $aliases) : void{
	$this->aliases = $aliases;
	if(!$this->isRegistered()){
	$this->activeAliases = $aliases;
	}
	}