-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add towncrier files to ignore or rename .keep
#6225
Comments
@stevepiercy .gitkeep is a convention there isn't anything magical about it's naming other than to be more clear that it's for git to keep the folder from deleting if it were empty. I opted to suggest to simply rename to .keep for plone/volto but as part as another pull request for this issue we could add .gitkeep as an ignore option to each package from the monorepo that uses towncrier if someone is willing todo it and contribute as a way to fix this issue this way. |
|
@stevepiercy Yes! |
Issue created at twisted/towncrier#643 with offer to submit PR, if the maintainers agree. |
PR merged twisted/towncrier#647. Awaiting release to revert the file rename. |
Towncrier 24.8.0 was released today, and I merged the #6232. |
From a release on July 29, 2024, we need to either rename all towncrier fragments that we want to ignore to
.keep
or add.gitkeep
to towncrier's new ignore configuration.Reference: twisted/towncrier#622
@Tishasoumya-02 I know it's not your fault but the pull request isn't green
https://github.com/plone/volto/actions/runs/10196668962/job/28207886197?pr=6147
Due to
https://github.com/twisted/towncrier/blob/trunk/src/towncrier/_builder.py#L117
try to rename package/volto/news/.gitkeep to .keep as they recognize that as something to ignore.
Originally posted by @ichim-david in #6147 (comment)
The text was updated successfully, but these errors were encountered: