Undeprecate token parameter from vocabularies endpoint

[tisto]

Passing a token parameter to the vocabularies endpoint has been deprecated:

plone.restapi/src/plone/restapi/serializer/vocabularies.py

Line 46 in eac02a7

if token:

One should use "tokens" instead.

[tisto]

@sneridagh @davisagli I am unsure if we can remove allowing passing "token" instead of "tokens" parameter. Can you folks check if we do this properly in Volto 15, 16 and 17?

[tisto]

@sneridagh @davisagli does this mean that Volto currently sends both "token" and "tokens"?

https://github.com/plone/volto/blob/e91c4f95efe66c05c399bdc7a9d81987c245198d/src/actions/vocabularies/vocabularies.js#L73

[davisagli]

@tisto That particular code just passes through what was passed in to the request (token or tokens or both). You have to look at where that redux action is used

[tisto]

@sneridagh could you have a look at what we currently use in Volto 16 and 17? token or tokens? Dependent on what we use I'd make a decision on what to do...

[sneridagh]

@tisto we allow both, for backwards compat.

https://github.com/plone/volto/blob/b703425a07b4830bcdb58fbef8f0f25a0ddf5489/src/actions/vocabularies/vocabularies.js#L65

I don't know if we should remove the dual code from Volto as well... I'd leave it.

[tisto]

@sneridagh I'd say we remove "token" from plone.restapi 9 and deprecate it in Volto 17. We can then remove it in Volto 18. Otherwise, we risk incompatibilities between Volto and plone.restapi that are unnecessary.

[davisagli]

@sneridagh @tisto Currently volto can use either token or tokens, depending on whether the value is an array or not. I would personally prefer to keep supporting both in plone.restapi. I don't see a compelling reason to remove one of them. It would break compatibility of plone.restapi 10 with volto <17, and just make extra work for ourselves.

[sneridagh]

I also share the same feeling as David... it does not hurt, we document/use in code (the locations are also very localized, meaning they are not spreaded everywhere) just one.

[davisagli]

Done in #1708