Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both underscores and dashes in options #158

Open
mauritsvanrees opened this issue Sep 21, 2020 · 1 comment
Open

Allow both underscores and dashes in options #158

mauritsvanrees opened this issue Sep 21, 2020 · 1 comment

Comments

@mauritsvanrees
Copy link
Member

Most options have dashes, for example clear-untrusted-proxy-headers. But in the resulting wsgi.ini they need to be with underscores.
The Sentry options have underscores.

That's a bit confusing. If you use the wrong spelling, buildout may warn that you have an unused parameter, but it won't fail, so you may not notice.

Would it be okay to accept both spellings?
We could cleanup all options specified in the buildout config to dashes, or maybe duplicate them.

The only problem is that someone could accidentally use both option-foo and option_foo. If those two have a different value, we should quit with an error.

@jensens
Copy link
Member

jensens commented May 10, 2021

Agree, it either should fail or just magically work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants