Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer patch Products.CMFPlone. #30

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

mauritsvanrees
Copy link
Member

Plone 6.1.0a5 will use us directly.
This solves cyclic dependencies, and is incompatible with Plone 6.0.
This fixes #12

Depend on Zope>=5.10 as we use the new ZPublisher.zpublish to explicitly say the isURLInPortal should not be published, so should not be available on a URL. Now we can use a docstring again, which feels a bit nicer.

I have updated the coredev buildout 6.0 to use branch 2.x.

This solves cyclic dependencies, and is incompatible with Plone 6.0.

Depend on `Zope>=5.10` as we use the new `ZPublisher.zpublish` to explicitly say the `isURLInPortal` should not be published, so should not be available on a URL.
Now we can use a docstring again, which feels a bit nicer.
@mister-roboto

This comment was marked as resolved.

@mauritsvanrees
Copy link
Member Author

Test together with plone/Products.CMFPlone#4000

@mauritsvanrees mauritsvanrees merged commit c37c354 into master Aug 16, 2024
11 of 12 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-do-not-patch-cmfplone branch August 16, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not patch CMFPlone ourselves
2 participants