Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: sort replies by new, old, and default with top #468

Closed
plebeius-eth opened this issue Dec 22, 2024 · 3 comments
Closed

add: sort replies by new, old, and default with top #468

plebeius-eth opened this issue Dec 22, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

They are already sorted by top, but it says "best". It should say "top", and also allow to sort by new or old. We can add the other sort types later, once they get added to the API.

@plebeius-eth plebeius-eth self-assigned this Dec 22, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Dec 22, 2024
@plebeius-eth plebeius-eth added the enhancement New feature or request label Dec 22, 2024
@plebeius-eth
Copy link
Member Author

97c990e

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Dec 22, 2024
@estebanabaroa
Copy link
Member

we already have the code for sort by best if you want to add it https://github.com/plebbit/plebbit-react-hooks/blob/77aa5d00542414af0b13afe1e642960b0848aff5/src/stores/feeds/feed-sorter.ts#L98

we probably wont have top sort in replies because of plebbit/plebbit-js#44 (comment)

the reply sorts will probably only be

best
new
newFlat (telegram style flat conversations, where you see newer first, and scroll to older)
old
oldFlat (4chan style flat replies)

@estebanabaroa estebanabaroa reopened this Dec 23, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit Dec 23, 2024
@plebeius-eth plebeius-eth moved this from Todo to In Progress in seedit Dec 23, 2024
@plebeius-eth
Copy link
Member Author

plebeius-eth commented Dec 23, 2024

changed "top" to "best", using that algo

31058ca

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Dec 23, 2024
@plebeius-eth plebeius-eth removed this from seedit Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants