Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile info banner should disappear after 3 visits, not just one #458

Closed
plebeius-eth opened this issue Dec 18, 2024 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

Currently, this banner disappears after just 1 visit, so it's too ephemeral. It should probably disappear after 3 visits. It also needs an X to close it at any time. Closable info banners are not found on old reddit, but they are a very common UI element, so it shouldn't be an issue to have them.

@plebeius-eth plebeius-eth self-assigned this Dec 18, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Dec 18, 2024
@plebeius-eth plebeius-eth added the enhancement New feature or request label Dec 18, 2024
@plebeius-eth
Copy link
Member Author

d313a68
7730f64

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Dec 19, 2024
@estebanabaroa
Copy link
Member

maybe it should just be a regular × (multiplication sign)

also it probably shouldnt change color on hover, that's not very reddit like. reddit links usually underline or do nothing when you hover them. I think the x should probably not hover.

@estebanabaroa estebanabaroa reopened this Dec 23, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit Dec 23, 2024
@plebeius-eth plebeius-eth moved this from Todo to In Progress in seedit Dec 23, 2024
@plebeius-eth
Copy link
Member Author

changed it to that, it looks better

Image
Image

989b7bd

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Dec 23, 2024
@plebeius-eth plebeius-eth removed this from seedit Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants