Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format score to abbreviate it or it will overflow #448

Closed
plebeius-eth opened this issue Dec 14, 2024 · 2 comments
Closed

fix: format score to abbreviate it or it will overflow #448

plebeius-eth opened this issue Dec 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@plebeius-eth
Copy link
Member

e.g., a post score of 100,000 should be rendered as "100k", a post score of 1,000,000 should be rendered as "1m". Only showing the tenths after the decimal point, e.g. "12.5k".

@plebeius-eth plebeius-eth self-assigned this Dec 14, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Dec 14, 2024
@plebeius-eth plebeius-eth added the bug Something isn't working label Dec 14, 2024
@plebeius-eth
Copy link
Member Author

also just like on reddit, we should use Intl.NumberFormat with maximumFractionDigits set to 100000, so only numbers less than 100000 will show the decimal point

@plebeius-eth
Copy link
Member Author

6ce7fa9

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Dec 14, 2024
@plebeius-eth plebeius-eth removed this from seedit Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant