-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: too many comments in profile page freeze the app #365
Comments
you should use url params to set the tabs, this isn't good
|
you shouldnt calculate everything for all tabs at once
you should only do calculation if the user is on the tab, ie, you should use routes like this
also its probably good to use virtuoso for the accountComments, but the votes and hidden (anything that uses useComments to load) will probably work best with pagination [previous][next] because they are loading progressively so the infinite scroll isnt really gonna work. You actually dont even need to use useComments(), you can just have single component that calls useComment inside, and render an array of components at some point we need to have a useFeed like hook for votes and hidden but it's complicated to do and low priority as people rarely use these pages |
refactored with virtuoso for account comments, pagination for comments from votes and blocked cids |
https://t.me/plebbitjs/30554
https://t.me/seeditreact/6756
The text was updated successfully, but these errors were encountered: