Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search bar allows to connect to a sub address without a tld #349

Closed
plebeius-eth opened this issue May 22, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

it should check if the address is either a valid IPNS public key or contains a dot (for the tld), and no spaces or slashes

@plebeius-eth plebeius-eth self-assigned this May 22, 2024
@plebeius-eth plebeius-eth converted this from a draft issue May 22, 2024
@plebeius-eth plebeius-eth added the bug Something isn't working label May 22, 2024
@plebeius-eth
Copy link
Member Author

f4798f3

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit May 23, 2024
@plebeius-eth plebeius-eth added enhancement New feature or request bug Something isn't working and removed bug Something isn't working labels May 23, 2024
@estebanabaroa
Copy link
Member

estebanabaroa commented May 31, 2024

you should not validate the domain, plebbit-js already validates it. otherwise you'll have to change the validate code any time we add a new domain or new key

displaying the useSubplebbit().error should be enough to tell the user what to do

@estebanabaroa estebanabaroa reopened this May 31, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit May 31, 2024
@plebeius-eth plebeius-eth removed the status in seedit Jun 1, 2024
@plebeius-eth
Copy link
Member Author

a40442d

removed the validation checks and displaying the error message

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants