Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'loading comments' string in post view, hide reply form before comment is loaded #285

Closed
plebeius-eth opened this issue Mar 5, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

I think “all comments” should say “loading comments…”

not a bad idea, maybe with the ellipsis animation

Esteban Abaroa, [Mar 4, 2024 at 9:22:30 PM]:
you might want to remove the comment box before the comment is loaded, but keep it while the comment update is loading
imo its confusing to see the empty values with the comment box

@plebeius-eth plebeius-eth self-assigned this Mar 5, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Mar 5, 2024
@plebeius-eth plebeius-eth added the enhancement New feature or request label Mar 5, 2024
@plebeius-eth
Copy link
Member Author

a068691

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Mar 14, 2024
@estebanabaroa
Copy link
Member

I don't really like the fact that it shows "loading comments..." before the post data is loaded. maybe before the post data is loaded, we just hide the entire comment section, "all comments", "sort by", etc

then maybe once the post data is loaded (post.timestamp is defined), show the "loading comments..."

also the location of the state string is ugly imo:
image

also another issue is that it is possible to comment before the comments load, so why remove the comment box. as soon post.subplebbitAddress and post.cid are defined, it's possible to write a comment.

@estebanabaroa estebanabaroa reopened this Mar 15, 2024
@plebeius-eth
Copy link
Member Author

fixed: e276763

  • the whole reply area appears as soon as timestamp is defined
  • the reply form appears as soon as subplebbitAddress and cid are defined
  • 'loading comments' disappears as soon as replyCount is defined
  • state string has padding on top, it's closer to the replies area

@estebanabaroa
Copy link
Member

no loading string before comment is loaded
image

@estebanabaroa estebanabaroa reopened this Mar 24, 2024
@estebanabaroa
Copy link
Member

also I think I would remove the ellipsis animation from loading comments... it looks bad to have 2 ellipsis animations at once.

@plebeius-eth
Copy link
Member Author

e1a3745

@estebanabaroa
Copy link
Member

there's a big empty space before the state string and

also the comment update state string doesnt appear right away, there's like a 1 second lag. https://seedit.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk there's no lag on plebones https://plebones.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk

image

@estebanabaroa estebanabaroa reopened this Apr 6, 2024
@plebeius-eth
Copy link
Member Author

there's a big empty space before the state string and

also the comment update state string doesnt appear right away, there's like a 1 second lag. https://seedit.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk there's no lag on plebones https://plebones.netlify.app/#/p/redditdeath.sol/c/QmatyFJHBk2DsCv6LCNbV8qXvPYtqTwyCVzBPGboXy99yk

should be fixed now f40665d

@estebanabaroa
Copy link
Member

I think loading comments... should have an ellipsis, just not an animated ellipsis, because having 2 animations at the same time looks bad.

@estebanabaroa estebanabaroa reopened this May 31, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit May 31, 2024
@plebeius-eth plebeius-eth removed the status in seedit Jun 1, 2024
@plebeius-eth
Copy link
Member Author

I think loading comments... should have an ellipsis, just not an animated ellipsis, because having 2 animations at the same time looks bad.

yes that's better, fixed it b84e0fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants