Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use query string for context route #284

Closed
plebeius-eth opened this issue Mar 5, 2024 · 5 comments
Closed

use query string for context route #284

plebeius-eth opened this issue Mar 5, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

p/<sub>/c/<cid> is part of the protocol, the /context isn't
so ideally we would have a way to do it without adding unnecessary endpoints to the protocol
Im actually not a fan of using /context endpoint
at all
cause it wont work on other clients
maybe it should be ?context=1 or something
this way those links will work in any client
and the previewer could potentially pass query string like ?context=1 to the app
this will make the links work on all clients, but the seedit client specifically can check the context query string and do something extra
cause p/<sub>/c/<cid>/context will 404 on plebchan and plebones which isnt cool
but p/<sub>/c/<cid>?context=1 will work on all clients

@plebeius-eth plebeius-eth self-assigned this Mar 5, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Mar 5, 2024
@plebeius-eth
Copy link
Member Author

6516245

@plebeius-eth plebeius-eth added the enhancement New feature or request label Mar 5, 2024
@plebeius-eth plebeius-eth moved this from Done to In Progress in seedit Mar 8, 2024
@plebeius-eth
Copy link
Member Author

plebeius-eth commented Mar 8, 2024

@plebeius-eth plebeius-eth reopened this Mar 8, 2024
@plebeius-eth
Copy link
Member Author

b9d050c

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Mar 9, 2024
@estebanabaroa
Copy link
Member

Im still seeing context=1, shouldnt it be context=3 like on reddit?

@estebanabaroa estebanabaroa reopened this Mar 15, 2024
@plebeius-eth plebeius-eth removed the status in seedit Mar 15, 2024
@plebeius-eth
Copy link
Member Author

yes I forgot, changed it to 3 now 29891a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants