Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable some comment tools for failed or pending comments #283

Closed
plebeius-eth opened this issue Mar 5, 2024 · 4 comments
Closed

disable some comment tools for failed or pending comments #283

plebeius-eth opened this issue Mar 5, 2024 · 4 comments
Assignees
@plebeius-eth
Labels
bug Something isn't working enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

Many buttons can't work if a post is removed, deleted or failed. For example, the permalink button can't work for a failed post since it has no cid.
@plebeius-eth plebeius-eth self-assigned this Mar 5, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Mar 5, 2024
@plebeius-eth plebeius-eth added bug Something isn't working enhancement New feature or request labels Mar 5, 2024
@plebeius-eth
Copy link
Member Author

d6778a7
6e341e3

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Mar 5, 2024
@plebeius-eth
Copy link
Member Author

they are not hidden, they are disabled

@estebanabaroa
Copy link
Member

estebanabaroa commented Mar 15, 2024 •
edited
Loading

its possible to share a deleted/removed post, it's also possible to undelete a post, so the comment tool should still be there, it only makes sense to remove it for failed/pending

@estebanabaroa estebanabaroa reopened this Mar 15, 2024
@plebeius-eth plebeius-eth changed the title hide comment tools buttons for comments that are removed, deleted or failed disable some comment tools for failed or pending comments Mar 23, 2024
@plebeius-eth
Copy link
Member Author

the title of this issue was wrong, actually I only ended up disabling the tools for pending or failed posts, checking for the cid. You can already share or edit a removed/deleted comment

@plebeius-eth plebeius-eth removed this from seedit Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plebeius-eth plebeius-eth

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@estebanabaroa @plebeius-eth