Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Fix M5Stack Boards #1492

Open
10 tasks
tao-j opened this issue Nov 20, 2024 · 0 comments
Open
10 tasks

Batch Fix M5Stack Boards #1492

tao-j opened this issue Nov 20, 2024 · 0 comments

Comments

@tao-j
Copy link

tao-j commented Nov 20, 2024

Foreword:

not until I spent too much time in this PR then I realize that we need the framework version to be bumped into 3.x for this PR to be accepted. Right now we are stuck at 2.x:

But anyways, here is the PR to save others some effort

We would like to reduce the confusion and frustration of downtream users of pio such as esphome. So let's collect what we have so far.

First of all, M5Stack themselves don't have consistent naming in the code/url https://github.com/m5stack/M5Unified/blob/cf1aec372b840093811f18b10bf3a8a13ffd33e1/src/M5Unified.cpp#L537C1-L539C41
In the graphical design, they are consistent tho.

For example, here we have Stack prefix, then class name have not.

#elif defined ( ARDUINO_M5STACK_PAPER ) || defined ( ARDUINO_M5STACK_Paper )

        board = board_t::board_M5Paper;

Here, they dropped the Stack prefix, or their product is actually this name.

#elif defined ( ARDUINO_M5STICK_C ) || defined ( ARDUINO_M5Stick_C )

        board = board_t::board_M5StickC;

And notably espersif moves variant m5stick-c into m5stack-stickc https://github.com/espressif/arduino-esp32/commits/master/variants/m5stack_stickc

For ease of maintainance, let's follow expersif and have everything prefixed with m5stack.

List of requests

In this PR I will make sure we:

  1. use faster flash freq if I see report it's working.
  2. Move to qio
  3. have proper macro defined if I can find in https://github.com/m5stack/M5Unified

Basically I improved the PR/issue from the list below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant