You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
not until I spent too much time in this PR then I realize that we need the framework version to be bumped into 3.x for this PR to be accepted. Right now we are stuck at 2.x:
Foreword:
not until I spent too much time in this PR then I realize that we need the framework version to be bumped into 3.x for this PR to be accepted. Right now we are stuck at 2.x:
But anyways, here is the PR to save others some effort
We would like to reduce the confusion and frustration of downtream users of pio such as esphome. So let's collect what we have so far.
First of all, M5Stack themselves don't have consistent naming in the code/url https://github.com/m5stack/M5Unified/blob/cf1aec372b840093811f18b10bf3a8a13ffd33e1/src/M5Unified.cpp#L537C1-L539C41
In the graphical design, they are consistent tho.
For example, here we have
Stack
prefix, then class name have not.Here, they dropped the
Stack
prefix, or their product is actually this name.And notably espersif moves variant m5stick-c into m5stack-stickc https://github.com/espressif/arduino-esp32/commits/master/variants/m5stack_stickc
For ease of maintainance, let's follow expersif and have everything prefixed with
m5stack
.List of requests
In this PR I will make sure we:
qio
Basically I improved the PR/issue from the list below.
stickcplus2
stickcplus
stamp-c3
M5Paper
Catch all
The text was updated successfully, but these errors were encountered: