Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #127

Open
Raul-Barajas opened this issue Oct 26, 2024 · 1 comment
Open

Update documentation #127

Raul-Barajas opened this issue Oct 26, 2024 · 1 comment

Comments

@Raul-Barajas
Copy link

Some changes have been made in the way functions are defined; for example, OptiNode() does not work as in the first versions. Could you please update the documentation.

@dlcole3
Copy link
Collaborator

dlcole3 commented Nov 21, 2024

Hi @Raul-Barajas, apologies for the delay in responding. Is there an instance in the documentation that you are hoping would be updated? Or are you thinking the docs could highlight more clearly what is not supported in the new version? I do not think we list in the docs all the changes under the new version, but it is possible we could make more clear that some functions have been removed.

You are correct that OptiNode() is not longer supported in v0.6+. I think optinodes can be added now only via the @optinode macro or the function add_node. I do not think we have any instances of using OptiNode() in any of the current documentation examples, but please let us know if one was missed.

@jalving I also noticed that the docs include PlasmoPlots calls, though PlasmoPlots is restricted to older versions of Plasmo. I think this could be good to update as well. I can try to take a look at updating PlasmoPlots in the next couple weeks to make a version that's compatible with Plasmo v0.6+. I am assuming this will require releasing a new version of PlasmoPlots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants