Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Rust initialization macro #20

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

camelid
Copy link
Contributor

@camelid camelid commented Oct 3, 2023

Rust proc macros must be defined in a crate that exports only proc macros, so
there are now two crates. I re-exported the macro from the main crate, so users
will never need to explicitly depend on it. I also set the second crate's
version to be the same as the main one since they should be kept in sync.

@camelid
Copy link
Contributor Author

camelid commented Oct 3, 2023

Rustfmt automatically made some formatting changes. I can put them in a separate commit or revert them if that would be helpful.

@nicovank nicovank self-requested a review October 3, 2023 17:00
@nicovank nicovank self-assigned this Oct 3, 2023
@nicovank
Copy link
Collaborator

nicovank commented Oct 3, 2023

LGTM, thanks a lot, this is nicer!

@nicovank nicovank merged commit 659fa5d into plasma-umass:main Oct 3, 2023
1 check passed
@camelid camelid deleted the rust-macro branch October 3, 2023 20:48
@camelid
Copy link
Contributor Author

camelid commented Oct 3, 2023

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants