-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
added test case to check against race conditions of write with the ga…
…rbage collection
- Loading branch information
1 parent
401b17e
commit d660b0f
Showing
1 changed file
with
23 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d660b0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ... not the best way to do it. Can we go back to using pull requests ?
d660b0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even more because what you basically claim here is that POST works because ... you can exploit a memory leak that exist in async. Assuming that some of these rock-webapp could actually run for hours, what will happen in the end is that some ports will end up with as many connections as there has been writes done to them. Not exactly the best strategy ...
d660b0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, when the ruby port element gets GCed, the connection is not closed?
You should start an issue on this on https://github.com/rock-core/tools-orocosrb, this whould be a serious bug.
d660b0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, basically, and it is both a serious bug and a not-so-serious one.
It is a bug in async writer and reader code. These are usually created in the one-object-per-port category, not repeatedly like in the webapp. So, it is a bad bug with low impact.
d660b0f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rock-core/tools-orocosrb#20