Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notebooks available in Docker env #52

Closed
robmarkcole opened this issue Jul 18, 2018 · 7 comments
Closed

Make notebooks available in Docker env #52

robmarkcole opened this issue Jul 18, 2018 · 7 comments

Comments

@robmarkcole
Copy link

I've successfully run the Docker container but discovered that the example notebooks are not in the env by default, so am uploading them manually. Would be good if these were available by default

@sarasafavi
Copy link
Contributor

Hi @robmarkcole - can you clarify what you mean by example notebooks?

@robmarkcole
Copy link
Author

I mean, all of the notebooks in this repo

@sarasafavi
Copy link
Contributor

@robmarkcole all notebooks in this repo are available via the /tree listing once the local Jupyter server is active (e.g., http://localhost:8888/tree using the default config).

Happy to look into this further if you can provide a more detailed problem description -- otherwise, closing for now.

@robmarkcole
Copy link
Author

@sarasafavi the tree folder was empty, and I don't see the notebooks being added in the DOCKERFILE. A screenshot of my folder (with uploaded files) below:

image

@sarasafavi
Copy link
Contributor

sarasafavi commented Jul 19, 2018

Hi @robmarkcole -- I think there's some confusion here: the Notebook server is running against your host machine's local working directory; i.e., there's no "there" to upload anything to (and no need to add anything to the dockerfile). If you check, you're going to find the Notebooks you've "uploaded" to the server now exist in the directory from which your docker run command was executed.

See Step 2 here to understand how the host directory mapping happens when you do docker run.

The issue here is that you need to make sure you do the docker run command from within the root of your locally-cloned repo. Note the cd .. at the end of the command list here.

In other words, $PWD needs to be the top level of this repo. To illustrate:

cd <path-to-repo>/notebooks
docker run -it (etc)

Otherwise, the docker run command will not be able to map your host machine's path $PWD/jupyter-notebooks to the server's container, and the /tree listing will appear empty.

@robmarkcole
Copy link
Author

@sarasafavi I had indeed omitted the cd .. and in my ignorance assumed I was in a folder structured within the docker container. Cheers

@rumski20
Copy link

rumski20 commented Jul 27, 2022

I'm still having this same issue as described by @robmarkcole -- http://localhost:8888/tree shows up empty:
image

I'm on a windows OS and I tried running all of the variants listed here: https://github.com/planetlabs/notebooks#run-the-container
Also, I made sure that I'm at the root of the repo, when running docker run ...

Any help you can provide is much appreciated. I'm eager to check out these notebooks.


Update

I moved this to a new issue (#195) since I can't re-open this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants