Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto correct illegal http configs #57

Closed
GlenDC opened this issue Feb 20, 2024 · 3 comments
Closed

auto correct illegal http configs #57

GlenDC opened this issue Feb 20, 2024 · 3 comments
Assignees
Milestone

Comments

@GlenDC
Copy link
Member

GlenDC commented Feb 20, 2024

E.g. strip out Connection header when a http version higher then http/1.1 is requested.

@GlenDC GlenDC modified the milestones: v0.3, v0.2 Feb 20, 2024
@GlenDC GlenDC self-assigned this Feb 29, 2024
@GlenDC
Copy link
Member Author

GlenDC commented Apr 20, 2024

First step will be to collect a list of such headers that are only valid in certain http. versions, secure mode or other contexts... The Connection is already an example given here. The #67 (CH) issue also mentions already client hints only in secure mode. There might however be more, all can be listed here.... Question is if this needs to be a middleware or if perhaps we can just fo this as part of the UA web client?

@GlenDC
Copy link
Member Author

GlenDC commented Jan 13, 2025

Relates to sanitize_client_req_header, we can tackle this as part of a nice layer that can work with rules.

Related to #380

@GlenDC
Copy link
Member Author

GlenDC commented Jan 20, 2025

This is already handled nicely by sanitize_client_req_header. For now keeping it there is okay, Depending if there are issues with it in future or it grows too much we can move it somewhere else, even though not sure where. For now it's ok as-is.

Client-Hints are for now out of scope, as the UA Emulation will set it already correctly based on what is desired, and any pre-defined CH's are up to the user to have done correctly.

@GlenDC GlenDC closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant