Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assetic version #10

Open
glensc opened this issue May 13, 2017 · 4 comments
Open

assetic version #10

glensc opened this issue May 13, 2017 · 4 comments

Comments

@glensc
Copy link
Contributor

glensc commented May 13, 2017

what is assetic version this used to work?

i pulled latest:

kriswallsmith/assetic             v1.4.0                        Asset Management for PHP

and get various errors

  • SassCssAbsoluteFilterFilter not found
  • CssAbsoluteFilter not found
  • CacheBustingWorker::STRATEGY_MODIFICATION constant not present

also, why you have assetic and smarty in composer suggests, as clearly this package is only useful if both smarty and assetic are installed as well?

@glensc
Copy link
Contributor Author

glensc commented May 13, 2017

i tried all versions down to 1.0, no luch with any of them

  • "kriswallsmith/assetic": "1.4.*",
  • "kriswallsmith/assetic": "1.3.*",
  • "kriswallsmith/assetic": "1.2.*",
  • "kriswallsmith/assetic": "1.1.*",
  • "kriswallsmith/assetic": "1.0.*",

@pjparra
Copy link
Owner

pjparra commented May 17, 2017

Unfortunately, Assetic was not installed via composer on the project I am currently working on. It was just copied and paste, with no version indication...
I will try to find the exact version I am using.

In the meantime, you can certainly drop the lines refering to inexistent filters, they must have been deleted from Assetic since then and they are not vital to the plugin.
Regarding the CacheBustingWorker, it may be tougher to find a workaround. I'll try to update Assetic on my project and see what it does.

@pjparra
Copy link
Owner

pjparra commented May 17, 2017

I just looked through my git history, Assetic was updated in the 18th of January 2013. It seems to indicate v1.0.4 or v1.1.0-alpha1.

Could you try using one of these? (v1.1.0-alpha1 might not be a good idea, obviously)

@glensc
Copy link
Contributor Author

glensc commented May 17, 2017

thanks for looking into it.

i got something working by disabling broken stuff.

and regarding CacheBuster i could not understand how it ever worked, because such constants were never present in releases. i found only README.md describing code what you used, but no actual code. so i assume it was probably present for a while in alpha release.

but i need to think over how to integrate in my project, seems it's destined to work in url root (http://something/) and not supporting storing the cache and files outside document root.

also it seemed to be a bit slow, i want production version be completely static, not going via php code at all. maybe i should look into webpack instead.

so perhaps you could document a bit more {assetic} parameters, giving examples as well. the $root really confused me so i just edited and put my paths where it was totally wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants