Implement "to content script" via background page #29
Conversation
| if (message.target) { | ||
| const publicMethod = getContentScriptMethod(message.type); | ||
| return handleCall( | ||
| message, | ||
| sender, | ||
| publicMethod(message.target, ...message.args) | ||
| ); | ||
| } |
There was a problem hiding this comment.
This is the core of the forwarder at this point. Information about the original sender is not preserved yet.
I think I will turn MessengerMeta into an array where each step just prepends its own "sender" information, sort of like a stack trace.
| const sendMessage = !browser.tabs | ||
| ? async () => browser.runtime.sendMessage(makeMessage(type, args, target)) | ||
| : async () => | ||
| browser.tabs.sendMessage( | ||
| target.tabId, | ||
| makeMessage(type, args), | ||
| // `frameId` must be specified. If missing, the message is sent to every frame | ||
| { frameId: target.frameId ?? 0 } | ||
| ); |
There was a problem hiding this comment.
This is the current "routing" implementation.
Since getContentScriptMethod is specific to content scripts, it's clear what the direction is: If we can't message the CS directly, we must contact the background page.
| @@ -0,0 +1,33 @@ | |||
| export async function ensureScripts(tabId: number): Promise<void> { | |||
There was a problem hiding this comment.
Hey this looks familiar!
| target?: Target; | ||
|
|
||
| /** If the message is being sent to an intermediary receiver, also set the options */ | ||
| options?: Target; |
There was a problem hiding this comment.
Notification forwarding hasn't been implemented yet, so this is currently unused. I'll implement them separately
|
This is what the logging looks like. On the left, the sender. On the right, the background page logging the messages it receives (no mentions that they're actually just forwarded, at the moment)
|
Test:
Next:
Notes: