Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requirements parser handles trailing comments #315

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Requirements parser handles trailing comments #315

merged 1 commit into from
Feb 28, 2024

Conversation

clavedeluna
Copy link
Contributor

Overview

Requirements parser handles trailing comments. Trailing comments will be fully ignored from parsing.

Closes #310

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

drdavella
drdavella approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great, thanks!

@drdavella drdavella added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit 2d1d4e3 Feb 28, 2024
12 checks passed
@drdavella drdavella deleted the req branch February 28, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdavella drdavella drdavella approved these changes

@andrecsilva andrecsilva Awaiting requested review from andrecsilva andrecsilva is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requirements.txt parser needs to handle lines with trailing comments
2 participants
@clavedeluna @drdavella