Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codemod to deprecate logging.warn #206

Merged
merged 2 commits into from
Jan 10, 2024
Merged

codemod to deprecate logging.warn #206

merged 2 commits into from
Jan 10, 2024

Conversation

clavedeluna
Copy link
Contributor

@clavedeluna clavedeluna commented Jan 8, 2024

Overview

codemod that will fix logging.warn or {logger}.warn to ....warning

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (269469d) 96.26% compared to head (94a4fd9) 96.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   96.26%   96.25%   -0.01%     
==========================================
  Files          88       89       +1     
  Lines        4065     4089      +24     
==========================================
+ Hits         3913     3936      +23     
- Misses        152      153       +1     
Files Coverage Δ
src/core_codemods/__init__.py 100.00% <100.00%> (ø)
src/core_codemods/fix_deprecated_logging_warn.py 95.65% <95.65%> (ø)

@clavedeluna clavedeluna marked this pull request as ready for review January 9, 2024 10:43
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good overall, just a few small requests.

Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@clavedeluna clavedeluna added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 9d8fdc4 Jan 10, 2024
14 checks passed
@clavedeluna clavedeluna deleted the deprecated-warn branch January 10, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants