New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize Classes #53

Open

carlschroedl opened this issue Oct 22, 2017 · 0 comments

Labels

good first issue

Member

carlschroedl commented Oct 22, 2017

Currently the src and test classes are both in one flat folder due to ignorance about how PHP namespaces and autoloading work.

Some ideas for organizing:

We could move all of the basic classes like Candidate, Margin, Ballot, NBallot, Agenda, (did I miss any?) to a "domain" or "model" folder
GenericCollection and its subclasses could go in a "lists" folder
Calculator classes could go together
Comparators could go together
TieBreakers together

Not sure where Grouper or RankedPairGraph would live

carlschroedl changed the title ~~Reorganize Classes~~ Organize Classes

carlschroedl added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment