Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logging #45

Open
carlschroedl opened this issue Sep 10, 2017 · 4 comments
Open

Add Logging #45

carlschroedl opened this issue Sep 10, 2017 · 4 comments
Assignees
@andrewshell @carlschroedl
Milestone
MVP

Comments

@carlschroedl
Copy link
Member

As an election administrator I need a record of voters' rankings and the aggregate collective ranking so that I can satisfy open records requests.

One way to satisfy this is to add some logging. Minimally, we need to log the NBallots that are passed to RankedPairsCalculator.calculate(), and the CandidateList that is returned.

To satisfy this use case via logging, the deployment's logging configuration would need to be of appropriate verbosity to capture the messages. Concern for this could be obviated (aka hacked) by using a very high logging level like INFO(a bit much) or ERROR(clearly not appropriate in the long term).
@carlschroedl carlschroedl added this to the MVP milestone Sep 10, 2017
@carlschroedl carlschroedl self-assigned this Sep 22, 2017
@andrewshell
Copy link
Contributor

I'll see if I can get this setup tonight.

@carlschroedl
Copy link
Member Author

I made a first pass in this pull request
#47

@carlschroedl
Copy link
Member Author

I wasn't sure whether I should sign the issue to you in addition to asking for review on the pull request

@andrewshell andrewshell mentioned this issue Oct 8, 2017
Merged
@carlschroedl
Copy link
Member Author

We've merged some logging infrastructure. We have not yet added logging statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewshell andrewshell

@carlschroedl carlschroedl

Labels
None yet
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
2 participants
@andrewshell @carlschroedl