Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Implementation #41

Open
carlschroedl opened this issue Sep 6, 2017 · 1 comment
Open

Review Implementation #41

carlschroedl opened this issue Sep 6, 2017 · 1 comment
Assignees
@tylerharter @Jake-Gillberg

Comments

@carlschroedl
Copy link
Member

As anyone using this library, I want multiple discerning perspectives to have reviewed the code so that I have greater assurance that the code is free of defects and so that alternative implementation patterns and test cases are considered.
@carlschroedl
Copy link
Member Author

The repo's README.md provides a high-level overview of the algorithm. That would be a good thing to consult first to frame the problem. The best spot to start reviewing code is RankedPairCalculator.calculate. It might be helpful to glance at the basic classes earlier on in the review too. The basic classes are Candidate, Margin, CandidateList, MarginList, ListOfMarginLists and Ballot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tylerharter tylerharter

@Jake-Gillberg Jake-Gillberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tylerharter @carlschroedl @Jake-Gillberg