Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify packets before adding them to NACK buffer.
WARNING: DATA RACE
Read at 0x00c00056d456 by goroutine 10741:
github.com/pion/interceptor/pkg/nack.(*sendBuffer).get()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/pkg/nack/send_buffer.go:95 +0x1e4
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets.func1()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/pkg/nack/responder_interceptor.go:153 +0x70
github.com/pion/rtcp.(*NackPair).Range()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/transport_layer_nack.go:65 +0x43
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/pkg/nack/responder_interceptor.go:152 +0x124
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).BindRTCPReader.func1.gowrap1()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/pkg/nack/responder_interceptor.go:100 +0x44
Previous write at 0x00c00056d456 by goroutine 10735:
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets.func1()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/pkg/nack/responder_interceptor.go:186 +0x684
github.com/pion/rtcp.(*NackPair).Range()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/transport_layer_nack.go:65 +0x43
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).resendPackets()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/pkg/nack/responder_interceptor.go:152 +0x124
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).BindRTCPReader.func1.gowrap1()
/home/runner/go/pkg/mod/github.com/pion/[email protected]/pkg/nack/responder_interceptor.go:100 +0x44
Description
Reference issue
Fixes #...