Unbind stream for report interceptor #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 79.75% 79.71% -0.05%
==========================================
Files 70 70
Lines 3789 3791 +2
==========================================
Hits 3022 3022
- Misses 633 635 +2
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
boks1971
approved these changes
Jan 31, 2024
pkg/report/receiver_interceptor.go
Outdated
| @@ -143,7 +143,7 @@ func (r *ReceiverInterceptor) BindRemoteStream(info *interceptor.StreamInfo, rea | |||
| } | |||
|
|
|||
| // UnbindLocalStream is called when the Stream is removed. It can be used to clean up any data related to that track. | |||
cnderrauber
force-pushed
the
fix_unbind
branch
from
735ce51
to
c7535eb
Compare
UnbindLocalStream for Sender UnbindRemoteStream for Receiver
cnderrauber
force-pushed
the
fix_unbind
branch
from
c7535eb
to
284411c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnbindLocalStream for Sender
UnbindRemoteStream for Receiver