Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interdeparturethreshold should be 0 or a very small value like in google webrtc C++ code #190

Open
narayanaraorao opened this issue May 28, 2023 · 0 comments

Comments

@narayanaraorao
Copy link

narayanaraorao commented May 28, 2023

In pkg/gcc/arrival_group_accumulator.go, interDepartureThreshold is 5 * time.Millisecond, whereas google C++ implementation uses 0 here.
https://webrtc.googlesource.com/src//+/d090952628606228afa47c842812927f15227290/modules/congestion_controller/goog_cc/inter_arrival_delta.cc?autodive=#125

If we believe performance is an issue, we should use a very small value, like 100 microseconds. Otherwise, this introduces a large variation in delay, which occasionally causes delay estimator to signal overuse when there is no actual overuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant