Add an initial, very simple, jitter buffer #666
thatsnotrightlint.yaml
on: pull_request
lint
/
Metadata
12s
lint
/
Go
27s
Annotations
11 errors and 12 warnings
|
Invalid Go version:
go.mod#L3
Found 1.15. Expected 1.19
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L46
field `initialLatency` is unused (unused)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer_test.go#L47
unnecessary leading newline (whitespace)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer_test.go#L70
unnecessary leading newline (whitespace)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L46
err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(\"No previous sequence\")" (goerr113)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L55
err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(\"Priority item not found\")" (goerr113)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L103
err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(\"Attempt to pop without a current value\")" (goerr113)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L113
err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(\"Attempt to pop without a current value\")" (goerr113)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L134
err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(\"sequence not found\")" (goerr113)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L139
err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(\"Attempt to pop without a current value\")" (goerr113)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L160
err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(\"timestamp not found\")" (goerr113)
|
|
lint / Metadata
Restore cache failed: Dependencies file is not found in /home/runner/work/interceptor/interceptor. Supported file pattern: go.sum
|
|
lint / Go
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L87
unused-parameter: parameter 'event' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L19
error-naming: error var BufferUnderrun should have name of the form ErrFoo (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L20
error-naming: error var PopWhileBuffering should have name of the form ErrFoo (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L4
package-comments: should have a package comment (revive)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L12
exported: exported type PriorityQueue should have comment or be unexported (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L14
exported: exported type JitterBufferState should have comment or be unexported (revive)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L24
exported: exported function NewQueue should have comment or be unexported (revive)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L40
exported: exported method PriorityQueue.Find should have comment or be unexported (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L16
exported: exported type JitterBufferEvent should have comment or be unexported (revive)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L58
exported: exported method PriorityQueue.Push should have comment or be unexported (revive)
|