Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configurable ssh command and options everywhere #31

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

pinpox
Copy link
Owner

@pinpox pinpox commented Mar 27, 2024

  • The configured ssh command was not used for secret deployment which has been fixed.
  • REMOTE_SSH_OPTS are now used everywhere, not only for the nixos-rebuild command. This allows specifying custom ssh connection parameters, e.g. a non-standard port for SSH

- The configured ssh command was not used for secret deployment which has
been fixed.
- `REMOTE_SSH_OPTS` are now used everywhere, not only for the
  nixos-rebuild command. This allows specifying custom ssh connection
  parameters, e.g. a non-standard port for SSH
@GeoffreyFrogeye
Copy link
Contributor

I needed this and saw that it was still missing REMOTE_SSH_OPTS for deploy-flake. So I tried to add it myself: GeoffreyFrogeye@f93484c . Maybe there's a good reason for you not to do it that way, even though it worked for me. Otherwise, feel free to use :)

@pinpox
Copy link
Owner Author

pinpox commented Apr 3, 2024

I needed this and saw that it was still missing REMOTE_SSH_OPTS for deploy-flake. So I tried to add it myself: GeoffreyFrogeye@f93484c . Maybe there's a good reason for you not to do it that way, even though it worked for me. Otherwise, feel free to use :)

Nice, thank you! I added that one aswell.
This PR is ready to merge, I'm waiting for a bit of testing. Would you be able to test it with your setup and let me know if eveything works as expected?

Also, if you have other options that are missing and could be generally useful let me know!

@GeoffreyFrogeye
Copy link
Contributor

Yes, it worked perfectly on my 3-machines setup. On those I'm using the standard SSH command, but using a non-standard SSH port.

@pinpox pinpox merged commit 23e8069 into main Apr 4, 2024
2 checks passed
@pinpox pinpox deleted the use-ssh-opts branch April 4, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants