Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[page #100 ] - deployment YAML file not complete #30

Open
tkaagent opened this issue Dec 22, 2019 · 1 comment
Open

[page #100 ] - deployment YAML file not complete #30

tkaagent opened this issue Dec 22, 2019 · 1 comment

Comments

@tkaagent
Copy link

tkaagent commented Dec 22, 2019

deploy-webserver-do.yaml file should be corrected; As per page #100:

[..]
In both namespaces and the default namespace, create a deployment to launch a webserver pod:

#deploy-webserver-do.yaml
apiVersion: apps/v1

  • {key: app, operator: In, values: [webserver]}
    ^^^^^^^^^^^^^^^^^^^^^^^^

$ kubectl apply -f deploy-webserver-do.yaml -n default
deployment.extensions/webserver created
[..]

Recommendation:

apiVersion: apps/v1
kind: Deployment
metadata:
name: webserver
labels:
app: webserver
spec:
replicas: 1
selector:
matchLabels:
app: webserver
matchExpressions:
- {key: app, operator: In, values: [webserver]}
template:
metadata:
name: webserver
labels:
app: webserver
spec:
containers:
- name: webserver
image: contrailk8sdayone/contrail-webserver
securityContext:
privileged: true
ports:
- containerPort: 80

@pinggit
Copy link
Owner

pinggit commented Dec 23, 2019

that is right. it is missing in the official final PDF. it is in the raw draft though.
will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants