Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: got rpcClient is idle error during log meta restore #58845

Open
Tristan1900 opened this issue Jan 9, 2025 · 0 comments · May be fixed by #58963
Open

br: got rpcClient is idle error during log meta restore #58845

Tristan1900 opened this issue Jan 9, 2025 · 0 comments · May be fixed by #58963
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@Tristan1900
Copy link
Contributor

Tristan1900 commented Jan 9, 2025 •
edited
Loading

Bug Report

A customer found error rpcClient is idle during log restore and causes the restore to fail, looks like some issue with the client-go lib that when it recycles the connection a request comes in and will fail with such error.

At BR side we can probably add a retry logic and next try should create a new connection and works just fine

similar report tikv/client-go#568
@Tristan1900 Tristan1900 added the type/bug The issue is confirmed as a bug. label Jan 9, 2025
@Tristan1900 Tristan1900 changed the title br: add retry to TiKV rawkv api br: got rpcClient is idle error during log meta restore Jan 9, 2025
@jebter jebter added severity/major component/br This issue is related to BR of TiDB. labels Jan 14, 2025
@Tristan1900 Tristan1900 linked a pull request Jan 15, 2025 that will close this issue
Open
13 tasks
@BornChanger BornChanger added affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 may-affects-8.5 labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: add retry for raw kv client put Tristan1900/tidb
3 participants
@jebter @Tristan1900 @BornChanger